On Wed, Oct 14, 2020 at 6:15 PM Ajin Cherian <itsa...@gmail.com> wrote: >
I think it will be easier to review this work if we can split the patches according to the changes made in different layers. The first patch could be changes made in output plugin and the corresponding changes in test_decoding, see the similar commit of in-progress transactions [1]. So you need to move corresponding changes from v8-0001-Support-decoding-of-two-phase-transactions and v8-0004-Support-two-phase-commits-in-streaming-mode-in-lo for this. The second patch could be changes made in ReorderBuffer to support this feature, see [2]. The third patch could be changes made to support pgoutput and subscriber-side stuff, see [3]. What do you think? [1] - https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=45fdc9738b36d1068d3ad8fdb06436d6fd14436b [2] - https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=7259736a6e5b7c7588fff9578370736a6648acbb [3] - https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=464824323e57dc4b397e8b05854d779908b55304 -- With Regards, Amit Kapila.