Thanks! > 27 окт. 2020 г., в 16:43, Heikki Linnakangas <hlinn...@iki.fi> написал(а): > > gbt_ts_cmp(), gbt_time_cmp_sort() and gbt_date_cmp_sort() still have the > above issue, they still compare "upper" for no good reason. Fixed.
>> +static Datum
>> +gbt_bit_abbrev_convert(Datum original, SortSupport ssup)
>> +{
>> + return (Datum) 0;
>> +}
>> +
>> +static int
>> +gbt_bit_cmp_abbrev(Datum z1, Datum z2, SortSupport ssup)
>> +{
>> + return 0;
>> +}
>
> If an abbreviated key is not useful, just don't define abbrev functions and
> don't set SortSupport->abbrev_converter in the first place.
Fixed.
>
>> static bool
>> gbt_inet_abbrev_abort(int memtupcount, SortSupport ssup)
>> {
>> #if SIZEOF_DATUM == 8
>> return false;
>> #else
>> return true;
>> #endif
>> }
>
> Better to not set the 'abbrev_converter' function in the first place. Or
> would it be better to cast the float8 to float4 if SIZEOF_DATUM == 4?
Ok, now for 4 bytes Datum we do return (Datum) Float4GetDatum((float) z);
How do you think, should this patch and patch with pageinspect GiST functions
be registered on commitfest?
Thanks!
Best regards, Andrey Borodin.
v3-0001-Sortsupport-for-sorting-GiST-build-for-gist_btree.patch
Description: Binary data
