On Tue, Nov 10, 2020 at 10:21:04AM +0900, Michael Paquier wrote: > On Mon, Nov 09, 2020 at 03:47:22PM +0100, Peter Eisentraut wrote: >> You should just remove those calls. There is no need to replace them with >> vacuumdb calls. The reason those calls were there is that they were testing >> the generated script itself. If the script is gone, there is no more need. >> There are already separate tests for testing vacuumdb. > > True, 102_vacuumdb_stages.pl already does all that.
Let's fix that. From what I can see it only involves the attached, and as a bobus it also reduces the number of extra characters showing on my terminal after running pg_upgrade tests. -- Michael
diff --git a/src/bin/pg_upgrade/test.sh b/src/bin/pg_upgrade/test.sh
index 551ac8a5c2..04aa7fd9f5 100644
--- a/src/bin/pg_upgrade/test.sh
+++ b/src/bin/pg_upgrade/test.sh
@@ -243,8 +243,6 @@ esac
pg_ctl start -l "$logdir/postmaster2.log" -o "$POSTMASTER_OPTS" -w
-vacuumdb --all --analyze-in-stages
-
pg_dumpall --no-sync -f "$temp_root"/dump2.sql || pg_dumpall2_status=$?
pg_ctl -m fast stop
diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
index 9799c5f54b..266098e193 100644
--- a/src/tools/msvc/vcregress.pl
+++ b/src/tools/msvc/vcregress.pl
@@ -606,9 +606,6 @@ sub upgradecheck
print "\nStarting new cluster\n\n";
@args = ('pg_ctl', '-l', "$logdir/postmaster2.log", 'start');
system(@args) == 0 or exit 1;
- print "\nSetting up stats on new cluster\n\n";
- @args = ('vacuumdb', '--all', '--analyze-in-stages');
- system(@args) == 0 or exit 1;
print "\nDumping new cluster\n\n";
@args = ('pg_dumpall', '-f', "$tmp_root/dump2.sql");
system(@args) == 0 or exit 1;
signature.asc
Description: PGP signature
