On Mon, Nov 9, 2020 at 3:47 PM Peter Eisentraut <peter.eisentr...@enterprisedb.com> wrote: > > On 2020-11-09 11:22, Magnus Hagander wrote: > >> I have spotted one small-ish thing. This patch is missing to update > >> the following code in vcregress.pl: > >> print "\nSetting up stats on new cluster\n\n"; > >> system(".\\analyze_new_cluster.bat") == 0 or exit 1; > > Ah, nice catch -- thanks! I guess this is unfortunately not a test > > that's part of what cfbot tests. > > > > Untested on Windows, but following the patterns of the rows before it. > > I will go ahead and push this version in a bit. > > You should just remove those calls. There is no need to replace them > with vacuumdb calls. The reason those calls were there is that they > were testing the generated script itself. If the script is gone, there > is no more need. There are already separate tests for testing vacuumdb. >
Good point. Done. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/