On 2021-Jan-20, Michael Paquier wrote: > +/* > + * This is mostly duplicating ATExecSetTableSpaceNoStorage, > + * which should maybe be factored out to a library function. > + */ > Wouldn't it be better to do first the refactoring of 0002 and then > 0001 so as REINDEX can use the new routine, instead of putting that > into a comment?
I think merging 0001 and 0002 into a single commit is a reasonable approach. I don't oppose an initial refactoring commit if you want to do that, but it doesn't seem necessary. -- Álvaro Herrera 39°49'30"S 73°17'W
