Re: POC: postgres_fdw insert batching

[Ian Lawrence Barwick]

Hi

2021年1月21日(木) 8:00 Tomas Vondra <tomas.von...@enterprisedb.com>:

> OK, pushed after a little bit of additional polishing (mostly comments).
>
> Thanks everyone!
>

There's a minor typo in the doc's version of the ExecForeignBatchInsert()
declaration;
is:

    TupleTableSlot **
    ExecForeignBatchInsert(EState *estate,
                      ResultRelInfo *rinfo,
                      TupleTableSlot **slots,
                      TupleTableSlot *planSlots,
                      int *numSlots);

should be:

    TupleTableSlot **
    ExecForeignBatchInsert(EState *estate,
                      ResultRelInfo *rinfo,
                      TupleTableSlot **slots,
                      TupleTableSlot **planSlots,
                      int *numSlots);

(Trivial patch attached).


Regards

Ian Barwick

-- 
EnterpriseDB: https://www.enterprisedb.com

diff --git a/doc/src/sgml/fdwhandler.sgml b/doc/src/sgml/fdwhandler.sgml
index 854913ae5f..2e73d296d2 100644
--- a/doc/src/sgml/fdwhandler.sgml
+++ b/doc/src/sgml/fdwhandler.sgml
@@ -619,7 +619,7 @@ TupleTableSlot **
 ExecForeignBatchInsert(EState *estate,
                   ResultRelInfo *rinfo,
                   TupleTableSlot **slots,
-                  TupleTableSlot *planSlots,
+                  TupleTableSlot **planSlots,
                   int *numSlots);
 </programlisting>