On Mon, Feb 8, 2021 8:04 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Feb 8, 2021 at 12:22 PM osumi.takami...@fujitsu.com > <osumi.takami...@fujitsu.com> wrote: > > On Monday, February 8, 2021 1:44 PM osumi.takami...@fujitsu.com > > <osumi.takami...@fujitsu.com> > > > On Mon, Feb 8, 2021 11:36 AM Peter Smith <smithpb2...@gmail.com> > > > wrote: > > > > 2. For the 004 test case I know the test is needing some PK > > > > constraint violation # Check if DROP SUBSCRIPTION cleans up slots > > > > on the publisher side # when the subscriber is stuck on data copy > > > > for constraint > > > > > > > > But it is not clear to me what was the exact cause of that PK > > > > violation. I think you must be relying on data that is leftover > > > > from some previous test case but I am not sure which one. Can you > > > > make the comment more detailed to say > > > > *how* the PK violation is happening - e.g something to say which > > > > rows, in which table, and inserted by who? > > > I added some comments to clarify how the PK violation happens. > > > Please have a look. > > Sorry, I had a one typo in the tests of subscription.sql in v2. > > I used 'foo' for the first test of "ALTER SUBSCRIPTION mytest SET > > PUBLICATION foo WITH (refresh = true) in v02", but I should have used > 'mypub' to make this test clearly independent from other previous tests. > > Attached the fixed version. > > > > Thanks. I have integrated this into the main patch with minor modifications in > the comments. The main change I have done is to remove the test that was > testing that there are two slots remaining after the initial sync failure. > This is > because on restart of tablesync worker we again try to drop the slot so we > can't guarantee that the tablesync slot would be remaining. I think this is a > timing issue so it might not have occurred on your machine but I could > reproduce that by repeated runs of the tests provided by you. OK. I understand. Thank you so much that your modified and integrated it into the main patch.
Best Regards, Takamichi Osumi