On Sun, Apr 11, 2021 at 11:14:07AM -0400, Tom Lane wrote: > It's right: this is dead code because all paths through the if-nest > starting at line 1373 now leave results = NULL. Hence, this patch > has broken the autocommit logic; it's no longer possible to tell > whether we should do anything with our savepoint.
Ugh, that's a good catch from Coverity here. > Between this and the known breakage of control-C, it seems clear > to me that this patch was nowhere near ready for prime time. > I think shoving it in on the last day before feature freeze was > ill-advised, and it ought to be reverted. We can try again later. Yes, I agree that a revert would be more adapted at this stage. Peter? -- Michael
signature.asc
Description: PGP signature
