On Fri, Jun 11, 2021 at 12:37 PM Amit Langote <amitlangot...@gmail.com> wrote: > I will look at other parts of the patch next week hopefully. For > now, attached is a delta patch that applies on top of your v1, which > does: > > * Simplify partition_list_bsearch() and partition_lbound_datum_cmp() > * Make qsort_partition_list_value_cmp simply call > partition_lbound_datum_cmp() instead of having its own logic to > compare input bounds > * Move partition_lbound_datum_cmp() into partbounds.c as a static > function (export seems unnecessary) > * Add a comment for PartitionBoundInfo.isnulls and remove that for null_index
One more: * Add all columns of newly added test query in insert.sql to the order by clause to get predictably ordered output -- Amit Langote EDB: http://www.enterprisedb.com