On Fri, Jun 11, 2021 at 8:14 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, Jun 10, 2021 at 2:04 PM Ajin Cherian <itsa...@gmail.com> wrote: > > > > The new patches look mostly good apart from the below cosmetic issues. > I think the question is whether we want to do these for PG-14 or > postpone them till PG-15. I think these don't appear to be risky > changes so we can get them in PG-14 as that might help some outside > core solutions as appears to be the case for Jeff. The changes related > to start_replication are too specific to the subscriber-side solution > so we can postpone those along with the subscriber-side 2PC work. > Jeff, Ajin, what do you think? >
Since we are exposing two-phase decoding using the pg_create_replication_slot API, I think it is reasonable to expose CREATE_REPLICATION_SLOT as well. We can leave the subscriber side changes for PG-15. > Also, I can take care of the below cosmetic issues before committing > if we decide to do this for PG-14. Thanks, Regards, Ajin Cherian Fujitsu Australia