>>> Or, we should terminate the last cycle of benchmark regardless it is >>> retrying or not if -T expires. This will make pgbench behaves much >>> more consistent. > > I would tend to agree with this behavior, that is not to start any new > transaction or transaction attempt once -T has expired. > > I'm a little hesitant about how to count and report such unfinished > because of bench timeout transactions, though. Not counting them seems > to be the best option.
I agree. >> Hmmm, indeed this might make the behaviour a bit consistent, but I am >> not >> sure such behavioural change benefit users. > > The user benefit would be that if they asked for a 100s benchmark, > pgbench does a reasonable effort not to overshot that? Right. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
