On Wed, Jul 14, 2021 at 12:51 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > On 2021-Jul-13, Tomas Vondra wrote: > > > On 7/13/21 5:44 PM, Jeff Davis wrote: > > > > * Andres also mentioned that the function should not leak memory. > > > * One use case for this feature is when sharding a table, so the > > > expression should allow things like "hashint8(x) between ...". I'd > > > really like to see this problem solved, as well. > > .. > > > > Not sure about the memory leaks - I suppose we'd free memory for each row, > > so this shouldn't be an issue I guess ... > > I'm not sure we need to be terribly strict about expression evaluation > not leaking any memory here. I'd rather have a memory context that can > be reset per row. >
I also think that should be sufficient here and if I am reading correctly patch already evaluates the expression in per-tuple context and reset it for each tuple. Jeff, do you or Andres have something else in mind? -- With Regards, Amit Kapila.
