On Tue, Aug 24, 2021 at 7:13 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Tue, Aug 24, 2021 at 10:01 AM houzj.f...@fujitsu.com > <houzj.f...@fujitsu.com> wrote: > > > > > > > > > -----Original Message----- > > > From: Masahiko Sawada <sawada.m...@gmail.com> > > > Sent: Tuesday, August 24, 2021 8:52 AM > > > > > > Thanks. The patch for HEAD looks good to me. Regarding the patch for > > > PG14, I > > > think we need to update the comment as well: > > > > > > @@ -987,7 +986,7 @@ AlterSubscription(AlterSubscriptionStmt *stmt, bool > > > isTopLevel) > > > PreventInTransactionBlock(isTopLevel, "ALTER SUBSCRIPTION with > > > refresh"); > > > > > > /* Only refresh the added/dropped list of publications. */ > > > - sub->publications = stmt->publication; > > > + sub->publications = publist; > > > > > > > Thanks for the comment, attach new version patch which fixed it. > > Thank you for updating the patch! Looks good to me. >
Pushed! -- With Regards, Amit Kapila.
