On Mon, Aug 23, 2021 8:01 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Aug 23, 2021 at 2:45 PM > houzj.f...@fujitsu.com<houzj.f...@fujitsu.com> wrote: > > > > On Mon, Aug 23, 2021 12:59 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > On Sat, Aug 7, 2021 at 6:53 PM houzj.f...@fujitsu.com > > > <houzj.f...@fujitsu.com> wrote: > > > > > > > > Personally, I also think it will be better to make the behavior > > > > consistent. > > > > Attach the new version patch make both ADD and DROP behave the > > > > same as SET PUBLICATION which refresh all the publications. > > > > > > > > > > I think we can have tests in the separate test file > > > (alter_sub_pub.pl) like you earlier had in one of the versions. Use > > > some meaningful names for tables instead of temp1, temp2 as you had in the > previous version. > > > Otherwise, the code changes look good to me. > > > > Thanks for the comment. > > Attach new version patch which did the following changes. > > > > * move the tests to a separate test file (024_alter_sub_pub.pl) > > * adjust the document of copy_data option > > * add tab-complete for copy_data option when ALTER DROP publication. > > > > Thanks, the patch looks good to me. I have made some cosmetic changes in the > attached version. It makes the test cases easier to understand. > I am planning to push this tomorrow unless there are more comments or > suggestions.
Thanks ! The patch looks good to me. I noticed that the patch cannot be applied to PG14-stable, so I attach a separate patch for back-patch(I didn’t change the patch for HEAD branch). Best regards, Hou zj
v7-0001-PG14-Fix-Alter-Subscription-Add-Drop-Publication-refre_patch
Description: v7-0001-PG14-Fix-Alter-Subscription-Add-Drop-Publication-refre_patch
v7-0001-PG15-Fix-Alter-Subscription-Add-Drop-Publication-refre.patch
Description: v7-0001-PG15-Fix-Alter-Subscription-Add-Drop-Publication-refre.patch
