Andrew Dunstan <and...@dunslane.net> writes: > On 9/29/21 5:27 PM, Alvaro Herrera wrote: >> So, do we take the stance that we have no right to expect pg_basebackup >> to work if we didn't pass allow_streaming => 1? If so, the fix is to >> add it. But my preferred fix would be to call set_replication_conf if >> either allows_streaming or has_archiving are given. >> >> Another easy fix would be to call $primary2->set_replication_conf in the >> test file, but then you'd complain that that's supposed to be an >> internal method :-)
> It claims that but it's also used here: > src/bin/pg_basebackup/t/010_pg_basebackup.pl Given that precedent, it seems like calling set_replication_conf is a good quick-fix for getting the buildfarm green again. But +1 for then refactoring this to get rid of these hacks (both with respect to pg_hba.conf and the postgresql.conf parameters) in both of these tests. regards, tom lane