> Bruce Momjian writes:
> 
> > Done.  I did not change PQunixsocket or the unixsocket PQconnectdb
> > connection option.  Should they be changed too?
> 
> They should be removed because PQhost does this now.

I assume you mean PQunixsocket.  As part of the database connection, if
pghost begins with a slash, the value is assigned to pgunixsocket and
pghost is cleared.  Here is the code:

    /* ----------
     * Allow unix socket specification in the host name
     * ----------
     */
    if (conn->pghost && conn->pghost[0] == '/') 
    {
        if (conn->pgunixsocket)
            free(conn->pgunixsocket);
        conn->pgunixsocket = conn->pghost;  
        conn->pghost = NULL;
    }

Am I handling this properly?  I hate to be dragging around the unix
socket directory name in pghost for too long and hate to be propogating
the slash test throughout the code.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  [EMAIL PROTECTED]               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Reply via email to