Zdenek Kotala wrote: > 1) Naming convention: > > - Some probes uses "*end", some "*done". It would be good to select one name. > - I prefer to use clog instead of slru in probes name. clog is widely known.
But slru is also used in pg_subtrans and pg_multixact. Which maybe says that we oughta have separate probes for these rather than a single one in slru. Otherwise it's going to be difficult telling one from the other, yes? > Autovacuum_start probe is alone. I propose following probes for completeness: > > proc-autovacuum-start > proc-autovacuum-stop > proc-bgwriter-start > proc-bgwriter-stop Separate proc-autovacuum-worker-start and proc-autovacuum-launcher-start, perhaps. Not that I see any usefulness in tracking autovacuum launcher start and stop, but then if we're tracking bgwriter start and stop then it makes the same sense. > proc-master-start > proc-master-stop What's "master" here? -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
