On Mon, 2008-07-07 at 11:03 +0900, ITAGAKI Takahiro wrote: > Simon Riggs <[EMAIL PROTECTED]> wrote: > > > > The attached patch (executor_hook.patch) modifies HEAD as follows. > > > > > > - Add "tag" field (uint32) into PlannedStmt. > > > - Add executor_hook to replace ExecutePlan(). > > > - Move ExecutePlan() to a global function. > > > > The executor_hook.patch is fairly trivial and I see no errors. > > > > The logic of including such a patch is clear. If we have a planner hook > > then we should also have an executor hook. > > One issue is "tag" field. The type is now uint32. It's enough in my plugin, > but if some people need to add more complex structures in PlannedStmt, > Node type would be better rather than uint32. Which is better?
I was imagining that tag was just an index to another data structure, but probably better if its a pointer. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers