On Tue, 2008-07-15 at 16:25 +0900, ITAGAKI Takahiro wrote: > > > Also, after looking at the patch more closely, was there a good > reason > > > for making the hook intercept ExecutePlan rather than ExecutorRun? > > > > That raises the question of whether we should have ExecutorStart() > and > > ExecutorEnd() hooks as well, to round things off. > > Yeah, and also ExecutorRewind() hook. There are 4 interface functions > in executor. My addin only needs Run hook because it doesn't modify > the actual behavior of executor. However, when someone hope to replace > the behavior, they need all of the hooks. (Is multi-threaded executor > project still alive?)
No plans here, just thinking: if we do it, do it once. The reason I wasn't thinking about the rewind part though was it seems like someone might want to set up or tear down something at appropriate times, so adding Start/End felt "obvious". Yes, lets have Rewind also. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
