Re: [HACKERS] PATCH: CITEXT 2.0 v3

[David E. Wheeler]

On Jul 15, 2008, at 20:26, Tom Lane wrote:

"David E. Wheeler" <[EMAIL PROTECTED]> writes:

So I guess my question is: what is wrong with the  properties for
citextsend/citextrecv

[ checks catalogs... ] textsend and textrecv are marked STABLE not
IMMUTABLE.  I am not totally sure about the reasoning offhand --- it
might be because their behavior depends on client_encoding.

Thanks. Looks like maybe the xtypes docs need to be updated?

  http://www.postgresql.org/docs/8.3/static/xtypes.html

Anyway, changing them to "STABLE STRICT" appears to have done the trick (diff attached).

and what else might these failures be indicating
is wrong?

depending on binary equivalence of text and citext.

I think the other diffs are okay, they just reflect the fact that you're

Best,

David

Great, thanks. And with that, I think I'm just about ready to submit a new version of the patch, coming up shortly.

regression.diffs
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers