Tom Lane escribió: > Gregory Stark <[EMAIL PROTECTED]> writes: > > Tom Lane <[EMAIL PROTECTED]> writes: > >> BTW, there are at least two copies of that code to be changed. I'd > >> suggest grepping for assignments to t_hoff to be sure there aren't more.
Besides heap_form_tuple and heap_formtuple, we have heap_form_minimal_tuple head_addheader (it's also assigned to in heap_xlog_insert and heap_xlog_update, but I'm not sure they need anything changed) > > I did send in a patch a while ago to get rid of the old HeapFormTuple() and > > friends. > > I remember discussing that idea, but I don't recall seeing an actual > patch? It would have to be quite large because of the number of places > using the old way. I'd also be a bit worried about breaking add-on > modules to little purpose ... The good news is that it's easy to convert each caller (of which there are 57 currently BTW) to the new form; and we could just have heap_formtuple be a wrapper over heap_form_tuple, to reduce breakage. Maybe add a #warning about deprecation in there for a release or two. -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
