"Fujii Masao" <masao.fu...@gmail.com> writes:
> On Thu, Dec 18, 2008 at 4:49 AM, Robert Lor <robert....@sun.com> wrote:
>> My understanding is that we only want to track the XLogWrite when advancing
>> to the next buffer page, and if there is unwritten data in the new buffer
>> page, that indicates no more empty WAL buffer pages available, but I may be
>> wrong. I did some tests by adjusting wal_buffers, and I could observe this
>> behavior, more calls to XLogWrite with smaller wal_buffers.

> I understood your intention. But, I think that its function name is somewhat
> confusing.

I agree.  If the probe is meant to track only *some* WAL writes
then it needs to be named something less generic than
TRACE_POSTGRESQL_WAL_BUFFER_WRITE.

                        regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to