Andrew Dunstan wrote:
>
> Attached is the latest parallel restore patch. I think this is getting  
> fairly close.

Some random comments

- please #define the return type of prestore().  Also, that it returns
in one platform and exits in another seems weird as an API.  I think it
should return in both cases, and have the caller act appropriately.

- RestoreArchiveParallel has too many #ifdef WIN32.  It should be
possible to split it so that the cruft is contained better.

- Aren't there too many checks for libz presence?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to