On Mon, Jan 19, 2009 at 15:26, Brendan Jurd <dire...@gmail.com> wrote: > From the better-late-than-never department, comes a patch to improve > the handling of AM/PM and AD/BC markers in to_timestamp(), and up the > ante on error reporting for various kinds of invalid input.
Ok cool I tried this out and gave it a look over. Looks good to me, only a few nits below: -the various (only moved not added) strncpy(...) copy[len] = '\0'; just use strlcpy? -it seemed we were going to do the error messages the other way around "invalid value for "YYYY" in "a009" instead of "invalid value "a009" for "YYYY" but I think I like the latter (what you did in your patch) better anyways... so never mind -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
