On 2/9/09, Martijn van Oosterhout <klep...@svana.org> wrote: > On Mon, Feb 09, 2009 at 02:47:21PM +0200, Marko Kreen wrote: > > > That might be true but I know of apps that use them. Having the ability > to > > > migrate those slowly by using SET WITHOUT OIDS is a Good Thing (tm). > > > > +1 for removal. > > > > Also, whether the removal happens or not, I would suggest a setting that > > makes Postgres accept, but ignore default_with_oids / WITH OIDS settings. > > Err, you mean a setting that makes Postgres throw an error on the use > of WITH OIDS. Just silently ignoring the option is a fantastic way to > break applications silently.
For me, ignoring is easier... But yeah, error would be better, if it does not affect reloading the dump. > Making pg_dump not output the WITH OIDS option on tables may be an > easier option. I don't like it - it would require more work from users, but does not seem to be any way safer. You usually do the check if db works on restore time, not dump time... >From clarity standpoint, options that turns both default_with_oids and WITH OIDS to errors seems the best. -- marko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
