Heikki Linnakangas <[email protected]> writes:
> Perhaps this could be made less ugly by only having the ScanKeywords
> array in the .c file, and #including that into other .c files in
> src/backend/parser, ecpg and pg_dump.
What I'd suggest is something similar to the design of the errcodes.h
header: create a header file containing just the list of PG_KEYWORD
macro calls, and have the different users #include it after defining
that macro appropriately. Having .c files include other .c files is
usually best avoided on least-surprise grounds.
> Not sure what to do about ScanKeywordLookup function.
Yeah, duplicating that function is a bit annoying.
regards, tom lane
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
