Hi, On Wed, Apr 15, 2009 at 5:37 PM, Magnus Hagander <mag...@hagander.net> wrote: > This does not take into account the effect of symlinks as mentioned by > Itakagi Takahiro. I haven't looked at the details, but I don't think it > would be that much more work to deal with it - and as he mentions, this > is a very common usecase.
Okey, I'll revise the patch; create also the directory which is referenced by symlink if not present. > Also, wouldn't it be better to isolate this to the first time when we > try to create the file - then we don't have to export the symbol? You mean having assign_pgstat_temp_directory() create the directory instead of pgstat_start()? In this case, the directory is created automatically not only at the beginning but also when a configuration file is reloaded. This seems to be better behavior. One problem of this is that some directories may be created unexpectedly if stats_temp_directory is specified at multiple locations. It's because assign_hook is called for each setting. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers