Hi, On Fri, May 15, 2009 at 12:36 AM, Simon Riggs <si...@2ndquadrant.com> wrote: > > On Wed, 2009-05-13 at 21:43 +0100, Simon Riggs wrote: >> On Wed, 2009-05-13 at 21:26 +0300, Heikki Linnakangas wrote: >> >> > This whole thing can be considered to be a new feature. >> >> recovery.conf will contain a new optional parameter: >> >> recovery_end_command (string) > > Implemented.
> + ereport(signaled ? FATAL : WARNING, > + (errmsg("recovery_end_command \"%s\": return > code %d", > + > xlogRecoveryEndCmd, rc))); In fast failover case, pg_standby has to delete the trigger file immediately if it's found. Otherwise, recovery may go wrong as I already described. http://archives.postgresql.org/pgsql-hackers/2009-04/msg01139.php So, in fast mode, recovery_end_command would always fail to delete the trigger file, and cause warning. This is odd behavior, I think. We should change WARNING to DEBUG2 like RestoreArchivedFile() in the above code? Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers