Hi, On Tue, Jun 2, 2009 at 3:40 PM, Heikki Linnakangas <[email protected]> wrote: > Fujii Masao wrote: >> >> On Tue, Jun 2, 2009 at 10:21 AM, Tom Lane <[email protected]> wrote: >>> >>> Fujii Masao <[email protected]> writes: >>>> >>>> Yes, the old xlog itself is not used again. But, the *old file* might >>>> be recycled and used later. The case that I'm looking at is that the >>>> symlink to a temporary area is recycled. Am I missing something? >>> >>> Actually, I think the right fix for that would be to add defenses to >>> xlog.c to not try to "recycle" a file that is a symlink. >> >> OK, I tweaked Aidan's patch. Thanks Aidan! >> >> http://archives.postgresql.org/message-id/[email protected] >> >> Changes are: >> - use lstat instead of stat >> - add #if HAVE_WORKING_LINK and #endif code > > Committed. I left out the "#ifdef HAVE_WORKING_LINK" and used S_ISREG() > instead of S_ISLNK. We use lstat + S_ISREG elsewhere too, so there should be > no portability issues.
Thanks a lot! Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
