Hi,
On Fri, Jun 5, 2009 at 5:10 PM, Fujii Masao <masao.fu...@gmail.com> wrote:
>> psql $DB_NAME -c "SELECT pg_stop_backup();"
>> sleep 10 # Why we need this?
>> rm /var/lib/pgsql/backup_in_progress
>> tar -rf /var/lib/pgsql/backup.tar /var/lib/pgsql/archive/
>
> Since all WAL files generated during backup have to be added into backup.tar,
> I guess that "sleep 10" waits until they are archived.
In v8.4, pg_stop_backup waits until all WAL files used during backup
are archived.
So, "sleep" is already unnecessary for standalone hot backup.
Here is one-line patch to get rid of the description of that needless
operation from
backup.sgml.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Index: doc/src/sgml/backup.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/backup.sgml,v
retrieving revision 2.127
diff -c -r2.127 backup.sgml
*** doc/src/sgml/backup.sgml 27 May 2009 12:28:55 -0000 2.127
--- doc/src/sgml/backup.sgml 5 Jun 2009 09:09:36 -0000
***************
*** 1335,1341 ****
psql -c "select pg_start_backup('hot_backup');"
tar -cf /var/lib/pgsql/backup.tar /var/lib/pgsql/data/
psql -c "select pg_stop_backup();"
- sleep 20
rm /var/lib/pgsql/backup_in_progress
tar -rf /var/lib/pgsql/backup.tar /var/lib/pgsql/archive/
</programlisting>
--- 1335,1340 ----
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
