Fujii Masao wrote: > Hi, > > On Fri, Jun 5, 2009 at 5:10 PM, Fujii Masao <masao.fu...@gmail.com> wrote: > >> psql $DB_NAME -c "SELECT pg_stop_backup();" > >> sleep 10 # Why we need this? > >> rm /var/lib/pgsql/backup_in_progress > >> tar -rf /var/lib/pgsql/backup.tar /var/lib/pgsql/archive/ > > > > Since all WAL files generated during backup have to be added into > > backup.tar, > > I guess that "sleep 10" waits until they are archived. > > In v8.4, pg_stop_backup waits until all WAL files used during backup > are archived. > So, "sleep" is already unnecessary for standalone hot backup. > > Here is one-line patch to get rid of the description of that needless > operation from > backup.sgml.
Good point, applied. Thanks. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
