Magnus Hagander <mag...@hagander.net> writes: > To fix that we'd just have to turn those functions all into returning > boolean and log with LOG instead. AFAIK, we've had zero reports of > this actually happening, so I'm not sure it's worth redesigning. > Thoughts?
I'm not really insisting on a redesign. I'm talking about the places where the code author appears not to have understood that ERROR means FATAL, because the code keeps plugging on after it anyway. As far as I can see, using ERROR at lines 3630, 3657, 3674, and 3693 is just plain bogus, and changing to LOG there requires no other fixing. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers