2009/8/2 Robert Haas <robertmh...@gmail.com>: > On Fri, Jul 31, 2009 at 8:46 AM, Pavel Stehule<pavel.steh...@gmail.com> wrote: >> 2009/7/31 Bernd Helmle <maili...@oopsware.de>: >>> --On Montag, Juli 27, 2009 15:24:12 +0200 Bernd Helmle >>> <maili...@oopsware.de> wrote: >>> >>>>> Hi, >>>>> >>>>> I sending a little bit modified version - I removed my forgotten >>>>> comment in gram.y >>>> >>>> Thanks, i'll look on it asap. >>> >>> Looks good now. >>> >>> Here is a slightly edited reviewed patch version. I've edited the docs and >>> fixed some spelling errors in a few error messages. It seems the patch >>> mangled some source comments in namespace.c, i've rearranged them and tried >>> to explain the purpose of VerifyCandidateNamedNotation(). I'm continuing >>> reviewing this but can't get on it again until sunday. >>> >>> Pavel, can you have a look at the docs part of this patch and watch out for >>> any gotchas? >>> >> >> I looked there and I thing it's very good. I have only one idea about >> samples in docs. Mathematical function isn't too much readable. Maybe >> some string concation or returning record should be more readable. >> >> create or replace function foo(a varchar, b varchar, uppercase boolean = >> false) >> returns varchar as $$ >> select when uppercase then 'a=' || a ', b=' || b >> else upper('a=' || a ', b=' || b) end; >> $$ language sql immutable strict; >> >> select foo('Hello','World'); >> select foo('Hello', World', true); >> select foo('Hello' as a, 'World' as b); >> select foo('Hello', 'World', true as uppercase); >> select foo(true as uppercase, 'World' as b, 'Hello' as b); >> >> or some similar >> >> Thank You very much >> Pavel > > What's the current status of this patch? Is someone (either Pavel or > Bernd) planning to update it further, or should it be marked Ready for > Committer?
Hello Bernard wrote so will look on it today - I expect so there will be only cosmetic changes in doc. Pavel > > Thanks, > > ...Robert > -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers