2009/8/9 Alvaro Herrera <alvhe...@commandprompt.com>: > Brendan Jurd escribió: > >> Here's version 6 of the EEEE patch, now with an all-new implementation >> of (normalised) scientific notation in numeric.c, via the functions >> numeric_out_sci() and get_str_from_var_sci(). So EEEE should now be >> able to represent the full gamut of the numeric type. > > I noticed an ugly pattern in NUMDesc_prepare calling a cleanup function > before every ereport(ERROR). I think it's cleaner to replace that with > a PG_TRY block; see attached.
Looks nice -- although doesn't have anything to do with the EEEE patch so perhaps deserves its own thread? > > I didn't go over the patch in much more detail. (But the > numeric_out_sci business got me thinking.) Got you thinking about what? I'd welcome any comments you have. Cheers, BJ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
