On Mon, Dec 14, 2009 at 6:11 AM, Simon Riggs <si...@2ndquadrant.com> wrote: > On Mon, 2009-12-14 at 11:09 +0100, Magnus Hagander wrote: >> On Mon, Dec 14, 2009 at 10:54, Heikki Linnakangas >> <heikki.linnakan...@enterprisedb.com> wrote: >> > * Please remove any spurious whitespace. "git diff --color" makes them >> > stand out like a sore thumb, in red. (pgindent will fix them but always >> > better to fix them before committing, IMO). >> >> +1 in general, not particularly for this patch (haven't checked that >> in this patch). >> >> Actually, how about we add that to the page at >> http://wiki.postgresql.org/wiki/Submitting_a_Patch? > > If we can define "spurious whitespace" it would help decide whether > there is any action to take, and when.
git defines it as either (1) extra whitespace at the end of a line or (2) an initial indent that uses spaces followed by tabs (typically something like space-tab, where tab alone would have produced the same result). git diff --check master tends to be useful here. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
