On Mon, Dec 14, 2009 at 12:51, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Dec 14, 2009 at 6:35 AM, Simon Riggs <si...@2ndquadrant.com> wrote: >> On Mon, 2009-12-14 at 06:21 -0500, Robert Haas wrote: >>> On Mon, Dec 14, 2009 at 6:11 AM, Simon Riggs <si...@2ndquadrant.com> wrote: >>> > On Mon, 2009-12-14 at 11:09 +0100, Magnus Hagander wrote: >>> >> On Mon, Dec 14, 2009 at 10:54, Heikki Linnakangas >>> >> <heikki.linnakan...@enterprisedb.com> wrote: >>> >> > * Please remove any spurious whitespace. "git diff --color" makes them >>> >> > stand out like a sore thumb, in red. (pgindent will fix them but always >>> >> > better to fix them before committing, IMO). >>> >> >>> >> +1 in general, not particularly for this patch (haven't checked that >>> >> in this patch). >>> >> >>> >> Actually, how about we add that to the page at >>> >> http://wiki.postgresql.org/wiki/Submitting_a_Patch? >>> > >>> > If we can define "spurious whitespace" it would help decide whether >>> > there is any action to take, and when. >>> >>> git defines it as either (1) extra whitespace at the end of a line or >>> (2) an initial indent that uses spaces followed by tabs (typically >>> something like space-tab, where tab alone would have produced the same >>> result). git diff --check master tends to be useful here. >> >> (2) is a problem that has been discussed before on hackers, anything >> like that should be changed. >> >> Why is (1) important, and if it is important, why is it being mentioned >> only now? Are we saying that all previous reviewers of my work (and >> others') removed these without ever mentioning they had done so? > > pgident will remove such white spaces and create merge conflicts for > everyone working on those areas of the code. I certainly mention this > in any review I do where it's applicable, and have been doing so for > some time. I also will certainly fix it for any code I commit. I > also mentioned it in the review that I did of Hot Standby.
I also always do this when committing other peoples patches (which I don't do as often as I should, but when I *do* do it..) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers