Simon Riggs wrote: > On Tue, 2009-12-22 at 18:17 +0200, Heikki Linnakangas wrote: >> Simon Riggs wrote: >>> By "add" I meant to write the feature, test and then support it >>> afterwards, not to re-discuss editing the Wiki. >> That's exactly what I meant too. I *did* write the feature, but you >> removed it before committing. > > I removed it because you showed it wouldn't work.
I did? I believe this is the discussion that lead to you removing it (6th of December, thread "Hot Standby, recent changes"): Simon Riggs wrote: > > On Sun, 2009-12-06 at 12:32 +0200, Heikki Linnakangas wrote: >> > 4. Need to handle the case where master is started up with >> > wal_standby_info=true, shut down, and restarted with >> > wal_standby_info=false, while the standby server runs continuously. And >> > the code in StartupXLog() to initialize recovery snapshot from a >> > shutdown checkpoint needs to check that too. > > I don't really understand the use case for shutting down the server and > then using it as a HS base backup. Why would anyone do that? Why would > they have their server down for potentially hours, when they can take > the backup while the server is up? If the server is idle, it can be > up-and-idle just as easily as down-and-idle, in which case we wouldn't > need to support this at all. Adding yards of code for this capability > isn't important to me. I'd rather strip the whole lot out than keep > fiddling with a low priority area. Please justify this as a real world > solution before we continue trying to support it. The issue I mentioned had nothing to do with starting from a shutdown checkpoint - it's still a problem if you keep the standby running through the restart cycle in the master) - but maybe you thought it was? Or was there something else? -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
