Tim Bunce <tim.bu...@pobox.com> writes: > I encountered a core dump running PL/Perl installcheck with a very > recent git HEAD of PostgreSQL and a not quite so recent git HEAD of perl.
> The cause is a subtle difference between SvTYPE(sv) == SVt_RV and > SvROK(sv). The former is checking a low-level implementation detail > while the later is directly checking "does this sv contains a reference". Hmm. Seems like this patch begs the question: if checking SvTYPE(*svp) isn't safe, why is it safe to look at SvTYPE(SvRV(*svp))? Shouldn't the tests against SVt_PVHV be made more abstract as well? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers