On Tue, Mar 23, 2010 at 05:10, Takahiro Itagaki <itagaki.takah...@oss.ntt.co.jp> wrote: > > Greg Smith <g...@2ndquadrant.com> wrote: > >> By the way: the pgbench.sgml that you committed looks like it passed >> through a system that added a CR to every line in it. Probably not the >> way you intended to commit that. > > Oops, fixed. Thanks.
My guess is that this happened because you committed from Windows? I learned the hard way that this is a bad idea. (Luckily I learned it on other CVS projects, before I started committing to PostgreSQL). There are settings to make it not do that, but they are not reliable. I'd strongly suggest that you always just do a cvs diff on windows and then use a staging machine running linux or bsd or something to apply it through. And then you *always* run those patches through something like "fromdos". It's a bunch of extra steps, but it's really the only way to do it reliably. If that's not at all what happened, then well, it's still good advice I think, even if it doesn't apply :-) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
