Tom Lane wrote: > The functions ShmemInitStruct and ShmemInitHash will return NULL on > certain failure conditions, apparently on the grounds that their caller > can print a more useful error message than they can. A quick survey > shows that about half the callers aren't remembering to check for NULL, > and none of the other half are printing messages that are more useful > than "out of shared memory" (which isn't even necessarily correct). > > I think that this is pretty error-prone, and that considering that > PG hackers are accustomed to not checking palloc() results, it's > inevitable that we'll make the same mistake in future if we leave > this API as it is. I suggest making these functions throw > their own errors rather than returning NULL on failure, and removing > the redundant error reports from the callers that have 'em.
+1. I was just annoyed by this when working on the known-assigned-xids hash -> sorted-array patch. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
