Stephen Frost <sfr...@snowman.net> writes:
> While reviewing bfba40e2c7b3909d3de13bd1b83b7e85fa8dfec2 (mmm, we like
> git diff -p), I noted that c.h is already included by both extern.h
> and ecpg.header through postgres_fe.h. Given this and that we're
> already doing alot of similar #define's there (unlike in those other
> files), I felt c.h was a more appropriate place. Putting it in c.h
> also means we don't have to duplicate that code.
Ugh. Moving that to c.h doesn't render it not junk code. (For one
thing, it will not operate as intended if you haven't previously
#included <limits.h>, which in fact is not included in c.h.)
If we need this we should do it properly with autoconf.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
