On Wed, Jun 23, 2010 at 4:56 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Fujii Masao <masao.fu...@gmail.com> writes: >> On Wed, Jun 23, 2010 at 5:32 AM, Robert Haas <robertmh...@gmail.com> wrote: >>> OK, here's a new version with several fewer bugs. > >> Since valid values for keepalives parameter are 0 and 1, its field size >> should >> be 1 rather than 10. > > Right ... although maybe it should be considered a boolean and not an > int at all?
Well, really, all libpq parameters are just strings, at this level. The dispsize is just a hint for, I guess, things like PGadmin; it's not actually used by libpq. >> In this case, you can check the value of keepalives parameter by seeing >> conn->keepalives[0] instead of using strtol() in useKeepalives(). > > I disagree with that idea, though. The field size has nothing to do > with most of the possible sources of the variable's value ... That is my thought also. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
