Alvaro Herrera <alvhe...@commandprompt.com> writes:
> Excerpts from Joseph Adams's message of mar ago 10 04:03:43 -0400 2010:
>> An overview, along with my thoughts, of the utility functions:
>>
>> FN_EXTRA, FN_EXTRA_ALLOC, FN_MCXT macros
>> * Useful-ometer: ()--------------------o
>>
>> TypeInfo structure and getTypeInfo function
>> * Useful-ometer: ()---------------------------o
>>
>> getEnumLabelOids
>> * Useful-ometer: ()-----------------------------------o
> I think this kind of thing could be stripped from the patch and
> submitted separately;
+1. It's easier all around if a patch does just one thing. Code
refactoring and feature addition, in particular, are easier to review
separately.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
