On Fri, Aug 27, 2010 at 9:35 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Alvaro Herrera <alvhe...@commandprompt.com> writes: >> Didn't we inject some smarts so that the compiler would notice that >> elog(ERROR) doesn't return? > > No. If you know a portable (as in "works on every compiler") way > to do that, we could talk. If only some compilers understand it, > we'll probably end up worse off --- the ones that don't understand it > will still need things like these unreachable assignments, while the > ones that do understand will start warning about unreachable code.
What's a bit odd about this is that I do get warnings for this kind of thing in general, which get turned into errors since I compile with -Werror; and in fact the version of the patch that I committed has no fewer than four places where there is a comment that says "placate compiler". But for some reason the compiler I used to develop this patch (gcc-4.2.1 i686-apple-darwin10) did not complain about this case, for reasons that are not quite clear to me. Which I guess also goes to your point. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
