On mån, 2010-11-15 at 23:34 -0500, Tom Lane wrote: > It's clear to me that we are very far from having a handle on what > it'll really take to run parallel builds safely, and I am therefore > now of the opinion that we ought to revert the patch. Hypothetical > gains in parallelism are useless if we can't actually use parallel > building reliably. We are currently worse off than before in terms of > time to build the system.
We don't have to revert it, we just have to insert .NOTPARALLEL targets into some places that are not properly "parallelized", thus effectively restoring the behavior of the old for loop. I have attached a patch that gets make -j 100+ working for me. Other platforms might need more things, perhaps. Btw., my original notes for this development were labeled "make make -k work properly". So I would really like to keep that. It just turned out that parallel make could benefit from the same changes, and it's a better marketing name. ;-)
diff --git i/src/Makefile w/src/Makefile index 0d4a6ee..a8d4e4b 100644 --- i/src/Makefile +++ w/src/Makefile @@ -26,6 +26,8 @@ SUBDIRS = \ makefiles \ test/regress +.NOTPARALLEL: + $(recurse) install: install-local diff --git i/src/interfaces/Makefile w/src/interfaces/Makefile index 2c034bc..9fe368e 100644 --- i/src/interfaces/Makefile +++ w/src/interfaces/Makefile @@ -15,3 +15,5 @@ include $(top_builddir)/src/Makefile.global SUBDIRS = libpq ecpg $(recurse) + +all-ecpg-recurse: all-libpq-recurse diff --git i/src/interfaces/ecpg/Makefile w/src/interfaces/ecpg/Makefile index d955cee..ca434c8 100644 --- i/src/interfaces/ecpg/Makefile +++ w/src/interfaces/ecpg/Makefile @@ -6,7 +6,8 @@ SUBDIRS = include pgtypeslib ecpglib compatlib preproc $(recurse) -all-compatlib-recursive: all-ecpglib-recursive +all-compatlib-recurse: all-ecpglib-recurse +all-ecpglib-recurse: all-pgtypeslib-recurse clean distclean maintainer-clean: $(MAKE) -C test clean
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
