On Sat, Nov 20, 2010 at 11:22 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Nov 4, 2010 at 3:39 PM, Dimitri Fontaine <dimi...@2ndquadrant.fr> > wrote: >> Tom Lane <t...@sss.pgh.pa.us> writes: >>> Not having read the patch, but ... the idea that was in the back of >>> my mind was to have a generic AlterObjectNamespace function that >>> would take parameters approximately like the following: >> >> Please find attached what I came up with, that's the set_schema patch >> version 6. > > Looks good overall, but: > > In AlterObjectNamespace(), you reference ACL_KIND_CONVERSION, which I > suspect actually needs to be yet another parameter to that function. > I've had the thought before that we have a deplorable number of > different ways of referring to object types in the back end: > ACL_KIND_*, OCLASS_*, OBJECT_*, and class IDs. We should maybe look > at unifying some or all of those. > > getObjectDescriptionOids() needs a prototype somewhere. > > And probably most significantly, you need to add docs and regression tests.
Ah, nuts. I see now there's a v7. Never mind... -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
