On Tue, Nov 30, 2010 at 18:18, David Fetter <da...@fetter.org> wrote: >> It expands all tables (and views) in tab-completion after INSERT, >> UPDATE, and DELETE FROM. Is it an intended change?
I found it was a simple bug; we need ( ) around selcondition. In addition, I modified your patch a bit: * I added a separated CREATE TRIGGER INSTEAD OF if-branch because it doesn't accept tables actually; it only accepts views. OTOH, BEFORE or AFTER only accepts tables. * I think "t.tgtype & (1 << N) <> 0" is more natural bit operation than "t.tgtype | (1 << N) = t.tgtype". Patch attached. If you think my changes are ok, please change the patch status to "Ready for Committer". -- Itagaki Takahiro
psql_view_trigger_tab_completion_6.diff
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
