On Wed, Jan 12, 2011 at 11:53 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Wed, Jan 12, 2011 at 11:00 AM, Stephen Frost <sfr...@snowman.net> wrote: >>> +1 for whatever the committer wants to commit. ;) > >> OK, done. :-) > > Uh, did you actually stop to *think* about this patch?
You have a valid point here, but this isn't the most tactful way of putting it. > What you have just committed puts a syscache lookup into the elog output > path. Quite aside from the likely performance hit, this will > malfunction badly in any case where we're trying to log from an aborted > transaction. > > Please revert and rethink. I think it's going to take more than a rethink - I don't see any way to salvage it. :-( -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
