2011/1/13 KaiGai Kohei <kai...@ak.jp.nec.com>: > I tried to pick up this patch to review. > > It seems to me fine, enough simple and works as explained in the > implementation level, apart from reasonability of this feature. > (Tom was not 100% agree with this feature 1.5month ago.)
Did you check whether this updated the code for 100% of the object types where this could apply? > I'm not certain whether the current regression test should be > updated, or not. The pg_regress launches psql with -q option, > so completionTag is always ignored. Well, I don't see any easy way of regression testing it, then. Am I missing something? Also, I don't really like the way this spreads knowledge of the completionTag out all over the backend. I think it would be better to follow the existing model used by the COPY and COMMIT commands, whereby the return value indicates what happened and standard_ProcessUtility() uses that to set the command tag. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
