Thanks for reviewing! On Fri, Jan 14, 2011 at 13:40, Robert Haas <robertmh...@gmail.com> wrote: > Did you check whether this updated the code for 100% of the object > types where this could apply?
I walked through all the CREATE statements in the documentation and these four seem to be the only ones that accept FOR REPLACE. There's a similar case with CREATE TABLE IF NOT EXISTS, maybe this is worth covering in an updated patch too? And if I change that, people might expect the same from DROP X IF EXISTS too? > Also, I don't really like the way this spreads knowledge of the > completionTag out all over the backend. I think it would be better to > follow the existing model used by the COPY and COMMIT commands, > whereby the return value indicates what happened and > standard_ProcessUtility() uses that to set the command tag. Right. I created this pattern after PerformPortalFetch() which already took a completionTag argument. But your approach seems more reasonable. Regards, Marti -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers